title tags must come before any svg tags to update the title

fixes bigskysoftware/htmx#459
strangeRabbit777 · May 17, 2021 · c85789e · c85789e
1 parent 68bac7e
commit c85789e
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 3 deletions.
diff --git a/src/htmx.js b/src/htmx.js
@@ -692,9 +692,13 @@ return (function () {
 
         var TITLE_FINDER = /<title>([\s\S]+?)<\/title>/im;
         function findTitle(content) {
-            var result = TITLE_FINDER.exec(content);
-            if (result) {
-                return result[1];
+            if(content.indexOf('<title>') > -1 &&
+                (content.indexOf('<svg>') == -1 ||
+                    content.indexOf('<title>') < content.indexOf('<svg>'))) {
+                var result = TITLE_FINDER.exec(content);
+                if (result) {
+                    return result[1];
+                }
             }
         }
 

diff --git a/test/core/ajax.js b/test/core/ajax.js
@@ -789,6 +789,33 @@ describe("Core htmx AJAX Tests", function(){
         window.document.title.should.equal("htmx rocks!");
     });
 
+    it('svg title tags do not update title', function()
+    {
+        var originalTitle = window.document.title
+        this.server.respondWith("GET", "/test", function (xhr) {
+            xhr.respond(200, {}, "<svg><title>" + originalTitle + "UPDATE" + "</title></svg>Clicked!");
+        });
+        var btn = make('<button hx-get="/test">Click Me!</button>')
+        btn.click();
+        this.server.respond();
+        btn.innerText.should.equal("Clicked!");
+        window.document.title.should.equal(originalTitle);
+    });
+
+    it('title tags before svg title tags do update title', function()
+    {
+        var originalTitle = window.document.title
+        var newTitle = originalTitle + "!!!";
+        this.server.respondWith("GET", "/test", function (xhr) {
+            xhr.respond(200, {}, "<title>" + newTitle + "</title><svg><title>foo</title></svg>Clicked!");
+        });
+        var btn = make('<button hx-get="/test">Click Me!</button>')
+        btn.click();
+        this.server.respond();
+        btn.innerText.should.equal("Clicked!");
+        window.document.title.should.equal(newTitle);
+    });
+
     it('title update does not URL escapte', function()
     {
         this.server.respondWith("GET", "/test", function (xhr) {