Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vite bundler documentation to admin panel customisation #1963

Merged
merged 9 commits into from
Jan 24, 2024

Conversation

joshuaellis
Copy link
Contributor

What does it do?

  • adds documentation around using vite as a bundler in V4

Why is it needed?

  • Because we're supporting two bundlers (in V5, webpack will be deprecated but not removed)

Related issue(s)/PR(s)

@joshuaellis joshuaellis self-assigned this Jan 3, 2024
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 4:07pm

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Josh. I created some style-related suggestions that I'll apply right away. It would be nice to add a "Default" column for the options table, just like we have in other documentation pages. I can do it if you want. Other than that, looks good to me.

docusaurus/docs/dev-docs/admin-panel-customization.md Outdated Show resolved Hide resolved
docusaurus/docs/dev-docs/admin-panel-customization.md Outdated Show resolved Hide resolved
docusaurus/docs/dev-docs/admin-panel-customization.md Outdated Show resolved Hide resolved
docusaurus/docs/dev-docs/admin-panel-customization.md Outdated Show resolved Hide resolved
docusaurus/docs/dev-docs/cli.md Outdated Show resolved Hide resolved
docusaurus/docs/dev-docs/cli.md Outdated Show resolved Hide resolved
docusaurus/docs/dev-docs/cli.md Outdated Show resolved Hide resolved
@pwizla pwizla assigned pwizla and unassigned joshuaellis Jan 9, 2024
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: new content PRs for new product features or new documentation sections labels Jan 9, 2024
@pwizla pwizla changed the title feat: add vite bundler documentation to admin panel customisation Add vite bundler documentation to admin panel customisation Jan 9, 2024
@joshuaellis
Copy link
Contributor Author

Thanks, Josh. I created some style-related suggestions that I'll apply right away. It would be nice to add a "Default" column for the options table, just like we have in other documentation pages. I can do it if you want. Other than that, looks good to me.

If you could add the default column, i'd really appreciate it 😄

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
(I've just added the "Default" column where appropriate).

When should we merge this one, @joshuaellis? (i.e., from which Strapi version will it work?)

@joshuaellis
Copy link
Contributor Author

The next release, which afaik is next wednesday 4.17.1 😄

@pwizla pwizla added this to the 4.17.1 milestone Jan 11, 2024
@pwizla pwizla added the flag: merge pending release Pending Strapi Release label Jan 15, 2024
@pwizla pwizla modified the milestones: 4.17.2, 4.19.0 Jan 17, 2024
@pwizla pwizla removed the flag: merge pending release Pending Strapi Release label Jan 24, 2024
@meganelacheny meganelacheny merged commit 9979c26 into main Jan 24, 2024
3 checks passed
@meganelacheny meganelacheny deleted the feat/add-vite branch January 24, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new content PRs for new product features or new documentation sections source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants