Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin cli docs page #1965

Merged
merged 9 commits into from
Feb 20, 2024
Merged

feat: add plugin cli docs page #1965

merged 9 commits into from
Feb 20, 2024

Conversation

joshuaellis
Copy link
Contributor

@joshuaellis joshuaellis commented Jan 3, 2024

What does it do?

  • adds plugin-cli docs page

Why is it needed?

  • so we can publicly document the plugin CLI as experimental

Related issue(s)/PR(s)

  • resolves CONTENT-1752

Direct preview links:
👉 Reference
👉 Guide

@joshuaellis joshuaellis self-assigned this Jan 3, 2024
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 8:58am

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @joshuaellis. Excited to see what the Plugin CLI will do!

However, when you create PR for docs, could you please disable your linter/Prettier tool(s)?

These tools autoformat content which often leads to "polluting" documentation PRs content.
At best, they convert single quotes into double quotes, and we don't need that level of strict conventions in documentation files, especially in files that are not exposed to the users (such as sidebars.js).
At worse, they introduce UX flaws — for instance, there's a very specific reason some lines are indented; indenting some blocks makes the difference between the following result:

Screenshot 2024-01-09 at 10 31 44

and the following one (notice how the block looks "included" into step 2):

Screenshot 2024-01-09 at 10 30 16

Before I dive deeper into the real content, could you please exclude/revert all the "pure formatting" content from this PR (removed spaces, converted quotes, etc.)? 🙏

(Also I changed the assignee because on the documentation repo, the assignee is the technical writer in charge of merging the PR; because a merge into main instantly triggers a new website deployment.)

@pwizla
Copy link
Collaborator

pwizla commented Jan 16, 2024

Hi @joshuaellis, FYI I'll probably go ahead and clean up the PR myself this week.
Is it for v4 or v5 btw? 🤔

@joshuaellis
Copy link
Contributor Author

Sorry @pwizla, been super busy. I'll try to get to it too, but let's see who does first. It's released in v4 as experimental...

I thought I disabled the workspace plugins last time too... have you looked at adding vscode workspace settings file? 😊

@pwizla
Copy link
Collaborator

pwizla commented Jan 17, 2024

It's OK @joshuaellis I can do it this time, no worries.

I've never played with workspace settings in VSCode, no, and wouldn't know where to start. However Derrick added an .editorconfig file a while back and I believe the file is still in the repo if you need it :)

@pwizla
Copy link
Collaborator

pwizla commented Jan 18, 2024

@joshuaellis I updated the formatting.
I'll now review the plugin CLI docs.
To save time, is it OK if I directly push updates to your branch, instead of having back & forth comments, discussions, and suggestions on GitHub?

@joshuaellis
Copy link
Contributor Author

absolutely! go right ahead ✨

@pwizla
Copy link
Collaborator

pwizla commented Jan 19, 2024

Hi @joshuaellis,

I finally had a deeper look at the PR.

I'll split the content because the current page actually groups 2 very different things:

  • a reference section (list of commands)
  • a guide on how to use the plugin CLI

For the guide part, I need a bit more context to properly introduce the subject and understand the added value of the feature. For instance, you can currently already create a plugin with strapi generate plugin. When should a user use this over the strapi plugin:init command? 🤔 Is there some additional internal documentation in Notion about the plugin CLI (esp. why it was created, what are the actual use cases, etc.)?

@joshuaellis
Copy link
Contributor Author

the plugin:init command will supersede the generate plugin command :)

The set up of the former is geared towards using the entire plugin CLI kit as opposed to the latter which is not.... I hope that helps? There aren't any other documents really that I can recall 🤔

@pwizla
Copy link
Collaborator

pwizla commented Jan 19, 2024

Thank you! So, at some point, we'll also need to rewrite the Plugin creation & setup page. Any ETA on when plugin:init will replace generate plugin?

@joshuaellis
Copy link
Contributor Author

Thank you! So, at some point, we'll also need to rewrite the Plugin creation & setup page. Any ETA on when plugin:init will replace generate plugin?

exactly! Hopefully in V5, still need to hash the details out – I can ping you on the PR when it's ready & in the JIRA ticket to keep an eye on if that's helpful for you?

@pwizla
Copy link
Collaborator

pwizla commented Jan 19, 2024

Sure, let's do this! For now I'll adapt the content of this PR to better fit with the current content, hierarchy and style guide. I'll ping you when it's done for a final review :)

@pwizla pwizla added the temp: port to v5 Temporary label for PRs that need to be ported to v5 docs label Jan 19, 2024
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: new content PRs for new product features or new documentation sections labels Jan 19, 2024
@pwizla
Copy link
Collaborator

pwizla commented Jan 25, 2024

@joshuaellis, I reworked the content a bit. If you'd like to have a look:

Direct preview links:
👉 Reference
👉 Guide

@joshuaellis
Copy link
Contributor Author

L O V E
I T

I Love It Reaction GIF by Magic: The Gathering

@pwizla pwizla added this to the 4.20.2 milestone Feb 20, 2024
@pwizla pwizla merged commit 00dc22d into main Feb 20, 2024
3 checks passed
@pwizla pwizla deleted the feat/add-plugin-cli branch February 20, 2024 13:35
@pwizla pwizla added internal PRs created by the Strapi core team and removed temp: port to v5 Temporary label for PRs that need to be ported to v5 docs labels Feb 20, 2024
pwizla added a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs created by the Strapi core team pr: new content PRs for new product features or new documentation sections source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants