Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created an Introduction page for the User Guide and the General Settings Section #2024

Merged
merged 30 commits into from
Mar 6, 2024

Conversation

MbonuJennifer
Copy link
Contributor

In this PR:

Fixed Typos and broken links on the User Guide Welcome page.

@MbonuJennifer MbonuJennifer added source: User Guide PRs/issues targeting the User Guide pr: typo PRs only fixing typos in the text instructions (excl. code samples, use "pr: code fix" instead) pr: chore labels Feb 19, 2024
@MbonuJennifer MbonuJennifer added this to the 4.20.2 milestone Feb 19, 2024
@MbonuJennifer MbonuJennifer self-assigned this Feb 19, 2024
@strapi-cla
Copy link

strapi-cla commented Feb 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pwizla
❌ MbonuJennifer
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 4:20pm

@pwizla pwizla added pr: updated content PRs updating existing documentation content pr: new content PRs for new product features or new documentation sections internal PRs created by the Strapi core team and removed pr: typo PRs only fixing typos in the text instructions (excl. code samples, use "pr: code fix" instead) pr: chore pr: updated content PRs updating existing documentation content labels Feb 20, 2024
@MbonuJennifer MbonuJennifer changed the title User/new intro Created an Introduction page for the User Guide and the General Settings Feb 21, 2024
@MbonuJennifer MbonuJennifer changed the title Created an Introduction page for the User Guide and the General Settings Created an Introduction page for the User Guide and the General Settings Section Feb 21, 2024
Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Jennifer!

I feel like the new version of the General Settings introduction is much better. It is short, guides users; it does the job. I left a few comments about consistency, though.

It's also great that you took the time to retake screenshots 👏 The new screenshots highlight the new lock icon 🔒 that has recently been introduced to mention disabled paid features — great idea!
There's just one screenshot that I suggest you re-take, though, because I feel like we're losing some information: for API tokens, in the previous version of the screenshot the UI showed how it looks like when a token has just been generated, and we can't see it anymore in your new screenshot. Unless the Strapi UI itself has changed (in this case, I didn't know 🙈), I'd suggest you reproduce the exact same screenshot (it should show the big key icon and the API token string visible). (see screenshot 👇)

Screenshot 2024-03-01 at 14 00 01

Apart from this, good job, I have nothing else to mention and IMHO once my suggestions are taken into account, we should be really close to merge 🚀 (but waiting for Mégane's feedback too 😄)

docusaurus/docs/user-docs/settings/introduction.md Outdated Show resolved Hide resolved
docusaurus/docs/user-docs/settings/introduction.md Outdated Show resolved Hide resolved
@pwizla pwizla self-requested a review March 6, 2024 09:58
Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MbonuJennifer! I left only 2 inline comments (and you can directly apply the suggestions from GitHub if you want) and then it will be good for me! 🚀

@pwizla pwizla self-requested a review March 6, 2024 10:01
…mental file to include badges for Cloud Dev, Cloud Pro, and Cloud Team features
@pwizla pwizla merged commit 7bb2635 into main Mar 6, 2024
1 of 3 checks passed
@pwizla pwizla deleted the user/new-intro branch March 6, 2024 16:19
pwizla added a commit that referenced this pull request Mar 27, 2024
@pwizla pwizla removed the temp: port to v5 Temporary label for PRs that need to be ported to v5 docs label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs created by the Strapi core team pr: new content PRs for new product features or new documentation sections source: User Guide PRs/issues targeting the User Guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants