Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value of develop's --open option #2029

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

bootleq
Copy link
Contributor

@bootleq bootleq commented Feb 22, 2024

Minor fix, the value in "Default" column is false, which is incorrect.

What does it do?

Fix incorrect value, also remove redundant one in "Description" column.

- The default is `true`.
- Move it from "Description" to dedicated "Default" column.
@bootleq bootleq requested a review from pwizla as a code owner February 22, 2024 07:39
Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 7:40am

@strapi-cla
Copy link

strapi-cla commented Feb 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bootleq!
It's approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release.

@pwizla pwizla self-assigned this Feb 22, 2024
@pwizla pwizla added this to the 4.20.3 milestone Feb 22, 2024
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: chore labels Feb 22, 2024
@pwizla pwizla merged commit ba164a0 into strapi:main Feb 22, 2024
3 checks passed
@bootleq bootleq deleted the dev/cli-open branch February 22, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants