Fix table overflow behavior on mobile #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pwizla
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Thanks, @nc1z!
It's approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release.
pwizla
added
source: Dev Docs
pwizla
added
the
temp: port to v5
pwizla
removed
the
temp: port to v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Updated scss for
tableelement so that table overflow doesn't push screen out of bounds on mobile.Why is it needed?
UI bug that should be fixed for UX. This happens across the entire documentation sites, whenever we have
<code>wrapped text in the tables that are too long, and pushes the table out of the viewport bounds.Changes Made
auto<Annotations>usage isn't affected by initial or auto (see #How to test). No existing impact since there are no current implementations of annotation component within markdown tablesScreenshots & gifs
Before Fix - iPhone 14 Pro Max Example
This was tested on an iPhone 14 plus in real life as well.
Link: https://docs.strapi.io/dev-docs/backend-customization/requests-responses
How to test
<Annotation>to a markdown table to make sure that changes don't affect it's usageRelated issue(s)/PR(s)
-