-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
@frames75 is attempting to deploy a commit to the Strapi Team on Vercel. A member of the Team first needs to authorize it. |
frontend/gatsby-config.js
Outdated
icons: [ | ||
{ | ||
src: `src/images/my-icon.png`, | ||
sizes: `48x48`, | ||
type: `image/png`, | ||
}, | ||
{ | ||
src: `src/images/my-icon.png`, | ||
sizes: `72x72`, | ||
type: `image/png`, | ||
}, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @frames75 thanks for your PR. I think you can remove this array and we can use automatic mode https://www.gatsbyjs.com/plugins/gatsby-plugin-manifest/#automatic-mode-configuration.
You'll need to add the image in src/images
. Could you change the name to favicon.png or default-icon.png
For reference you can see how it is setup on: https://github.com/strapi/strapi-starter-gatsby-catalog/blob/main/frontend/gatsby-config.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's perfect.
I changed the icon parameter to icon: 'src/images/favicon.png'
and added the src/images/favicon.png
, obtained from the strapi-starter-gatsby-catalog.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/strapijs/strapi-starter-gatsby-blog/ANVsycrh9pBPzDbfFebSYLN6dQcn |
frontend/gatsby-config.js
Outdated
@@ -32,6 +32,8 @@ module.exports = { | |||
background_color: "#663399", | |||
theme_color: "#663399", | |||
display: "minimal-ui", | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but could you please remove this space 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Best regards.
Building the frontend, when you do:
$ cd frontend $ npm install $ npm run develop
This last command returns next error:
The Error is solved by adding to
frontend/gatsby-config.js
the properties icon and icons.It's not necessary to add the icons files.
Linux Mint 19.2
Strapi: v3.4.0
Node.js: v14.15.3