Use { passive: false } in addEventListener to allow for preventDefault #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielchabr
approved these changes
Apr 30, 2019
scottyantipa
force-pushed
the
touch-action
branch
2 times, most recently
from
24d99ef
to
87a0e67
Compare
Fixes #23. No functional change. https://developers.google.com/web/updates/2017/01/scrolling-intervention As of today, this has not been solved by React: facebook/react#8968
scottyantipa
force-pushed
the
touch-action
branch
from
87a0e67
to
1f4b05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23. No functional change.
https://developers.google.com/web/updates/2017/01/scrolling-intervention
As of today, this has not been solved by React: facebook/react#8968