Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate GitHub source tarfile naming #509

Closed
wants to merge 1 commit into from
Closed

Conversation

mulkieran
Copy link
Member

No description provided.

@mulkieran mulkieran self-assigned this Mar 8, 2024
@mulkieran mulkieran marked this pull request as draft March 8, 2024 01:03
Copy link
Member

@bgurney-rh bgurney-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This almost worked, but not quite; mock failed to find the directory after the tar file was extracted.

I just tested this, and it works:

    source_tarfile_path = make_source_tarball(
        "stratisd", f"stratisd-v{release_version}", output_path
    )

I'll add this to a PR that updates mockbuild_test/stratisd.spec. (I didn't discover this until I updated the "mock --rebuild" command to add "--no-cleanup-after", so I could run "ls" in the /var/lib/mock directory of the chroot config (e.g.: ls /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD). By default, the buildroot is cleaned up afterward, even after a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants