Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dynamic build for Manager class #1042

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Use dynamic build for Manager class #1042

wants to merge 14 commits into from

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Nov 27, 2023 •
edited
Loading

Related #1033

@mulkieran mulkieran self-assigned this Nov 27, 2023
@mulkieran mulkieran force-pushed the issue_stratis-cli_1033 branch 2 times, most recently from f60cbfb to b166f92 Compare November 27, 2023 18:58
@mulkieran
Copy link
Member Author

mulkieran commented Nov 27, 2023 •
edited
Loading

make_dyn_class should memo-ize the dynamically generated classes, and should take a list of keys.

@mulkieran mulkieran force-pushed the issue_stratis-cli_1033 branch 5 times, most recently from 3cb269c to 69828b1 Compare November 28, 2023 14:25
@mulkieran
Copy link
Member Author

The invocations of make_dyn_class are too wordy. They should be super simple, just one arg which very closely resembles the class name. make_dyn_class should then interpret that one argument.

@mulkieran
Copy link
Member Author

Need to add into a test that invokes CreatePool.

@mulkieran
Sort out some tests
044e083 
Signed-off-by: mulhern <[email protected]>
@mulkieran
Copy link
Member Author

This is not the correct way to do this. It should really be possible to make dynamic self-generating classes, and that would require working with dbus-python-client-gen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mulkieran mulkieran

Labels
None yet
Projects
tracking
Status: changelogs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mulkieran