Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stratisd 3.6.5 release notes #343

Merged

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Feb 21, 2024

@mulkieran mulkieran self-assigned this Feb 21, 2024
@mulkieran mulkieran marked this pull request as ready for review February 21, 2024 14:53
Copy link
Member

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you were just trying to call out the case that was causing problems, but it may be better to call out both the potential for deadlocks and describe the problem more generally.

Comment on lines 11 to 15
`stratisd` 3.6.5 includes a modification to its internal locking mechanism
which allows a lock with a smaller scope to be taken when a global lock is
blocked by relaxing the fairness restriction that would otherwise give that
global lock precedence. It also includes a number of housekeeping commits and
minor improvements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not entirely true. It doesn't just apply to global locks. For example, we would see the same behavior if we had a read lock on pool 1, then a queued write lock on pool 1, and even a read lock on pool 2. The basic idea is that lock acquisitions that conflict with the current lock are queued. The change allows locks that do not conflict with the currently acquired lock to skip the queue instead of being placed behind the queued conflicting locks.

@mulkieran
Copy link
Member Author

@jbaublitz Ok. This should be ready again.

@mulkieran mulkieran merged commit f81fc89 into stratis-storage:master Feb 22, 2024
3 checks passed
@mulkieran mulkieran deleted the stratisd-3.6.5-release-notes branch February 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants