Some minor tidies #1571
Merged
Some minor tidies #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of a useless comment and make a better header comment. Signed-off-by: mulhern <[email protected]>
These are generic reserved sectors, and the only definite relationship that they have to the MDA is that they come immediately after it. Signed-off-by: mulhern <[email protected]>
Don't make a 16 sector buffer when using only the first six sectors. Signed-off-by: mulhern <[email protected]>
We're only doing due diligence by verifying that the metadata is correct, anything less would be negligence. There isn't any real need to call it out this way. Signed-off-by: mulhern <[email protected]>
It passes the result from setup() through w/out change unless a static header was succesfully read. This way, our code only handles the interesting case, leaving the rest to well known methods of the Option and Result types. Signed-off-by: mulhern <[email protected]>
drckeefe
approved these changes
Jun 20, 2019
bgurney-rh
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all more-or-less cherry-picked from a larger commit to refactor static header and size functionality within the metadata module into separate modules. Fixing/removing and then moving seems better than moving and then fixing/removing.