Move device_identifiers from StaticHeader to BDA #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, improved the header docs. In this way StaticHeader can be made private to the metadata module and better encapsulation is achieved. It does not make much sense to export StaticHeader and all its public methods from the metadata module in order to make accessible a one-line convenience method. This ought also to ease further refactoring of the static header specific functionality into a separate module. Signed-off-by: mulhern <[email protected]>
|
This should also help a bit w #1573, by removing one obvious cross-cutting constraint. |
drckeefe
approved these changes
Jun 24, 2019
bgurney-rh
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.