Use map to simplify structure of setup a bit #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the method-level identifiers buf_loc_1 and buf_loc_2. The names still appear here and there, but now they are bound locally, in various match arms, and not globally within the method. Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
master-setup-map
branch
from
ace2189
to
fbc707e
Compare
|
@GuillaumeGomez I was finding this change hard to explain...so I thought it would be more efficient to just do it. I think it will facilitate #1586. |
waltdisgrace
approved these changes
Jul 16, 2019
drckeefe
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1573.