Tidy up a test about static header corruption #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the dependence on BDA and improve the name and comments. Improve assertions so that they will be more helpful on failure. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
rustfmt is still working on formatting within macros, and through various edits these two lines became way too long and were not automatically reformatted. Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
master-corruption-test
branch
from
b8dfaf8
to
77748a5
Compare
mulkieran
requested review from
bgurney-rh,
GuillaumeGomez,
jbaublitz and
waltdisgrace
GuillaumeGomez
approved these changes
Aug 8, 2019
jbaublitz
approved these changes
Aug 8, 2019
waltdisgrace
approved these changes
Aug 8, 2019
bgurney-rh
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1573.
This tidy should make it easier to move the test to the soon-to-be-made static_header module.