-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up udev tests #3542
Tidy up udev tests #3542
Conversation
It's trivial if the tests run to completion. |
691fc69
to
5957491
Compare
The first commit is enough to cause the f39 tests not to time out anymore, but the failure on the generic test comes back there and the f38 test is still timing out.
|
Besides using Related: stratis-storage/project#683 . |
33af47b
to
40d85c1
Compare
Something has just gone wrong w/ our loop tests on every platform:
All seem to be yielding clevis errors with three indicating that cryptsetup is not found. All of this should be quite orthogonal to any changes here. |
a2e3e10
to
08d3484
Compare
Waiting for resolution of #3543 |
08d3484
to
fc684a9
Compare
fc684a9
to
9bfd2fb
Compare
The _clean_up method always throws one of these in, so there is no point in doing it at the end of the test. Signed-off-by: mulhern <[email protected]>
It can be made redundant by having remove_stratis_setup raise an exception if there are still devices remaining. Also, this supports slightly better encapsulation. Signed-off-by: mulhern <[email protected]>
Without, the test will wait indefinitely for stratisd to handle the signal. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
9bfd2fb
to
4db2c99
Compare
No description provided.