Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How many templates can we have at max? #842

Open
lorbax opened this issue Apr 11, 2024 · 2 comments
Open

How many templates can we have at max? #842

lorbax opened this issue Apr 11, 2024 · 2 comments

Comments

@lorbax
Copy link
Collaborator

lorbax commented Apr 11, 2024

Trying to remove all todos from codebase, I incountered this one that requires a bit of discussion.
The lasts_new_template field of roles-logic-sv2::job_creator::JobsCreators is a Vec<NewTemplate>, so it is thought to store more than one template. On the other hand, the method on_new_prev_hash does not allow more than one template in the same field (>1 lengths are dealt with the above todo!), which is an inconsistency.

@Fi3 told me privately that this issue is not a priority, but I think that eventually this shall be fixed.
@GitGab19
Copy link
Collaborator

I don't know, I would fix it. But I don't know what secondary changes it would require. Do you have an idea on that?

@lorbax
Copy link
Collaborator Author

lorbax commented Apr 14, 2024

I don't know, I would fix it. But I don't know what secondary changes it would require. Do you have an idea on that?

Nope. I think that this requires some discussion!

lorbax added a commit to lorbax/stratum that referenced this issue Apr 16, 2024
@lorbax
Reported todo!'s as an issues on github
bbcdd66 
The remaining relevant todos in protocols are reported as github issues

stratum-mining#853
stratum-mining#842
@lorbax lorbax mentioned this issue Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GitGab19 @lorbax