Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MG test for false fallback activation #923

Open
GitGab19 opened this issue May 22, 2024 · 16 comments
Open

Add MG test for false fallback activation #923

GitGab19 opened this issue May 22, 2024 · 16 comments

Comments

@GitGab19
Copy link
Collaborator

This is more a reminder for me than an issue, but I preferred to open an issue to better track it.
We need to add a MG test for specific scenario described in issue #901, addressing suggestions given under PR #904, that has been merged yesterday.

@pavlenex pavlenex added this to the 1.0.2 milestone May 22, 2024
plebhash added a commit to plebhash/stratum that referenced this issue May 24, 2024
plebhash added a commit to plebhash/stratum that referenced this issue May 24, 2024
plebhash added a commit to plebhash/stratum that referenced this issue May 24, 2024
plebhash added a commit to plebhash/stratum that referenced this issue May 24, 2024
plebhash added a commit to plebhash/stratum that referenced this issue May 24, 2024
plebhash added a commit to plebhash/stratum that referenced this issue May 24, 2024
@plebhash plebhash self-assigned this Jun 1, 2024
@plebhash plebhash linked a pull request Jun 4, 2024 that will close this issue
5 tasks
@plebhash plebhash removed their assignment Jun 4, 2024
plebhash added a commit to plebhash/stratum that referenced this issue Jun 6, 2024
@Shourya742
Copy link
Contributor

taking this up

@plebhash plebhash assigned Shourya742 and unassigned plebhash Jun 25, 2024
@GitGab19

This comment was marked as resolved.

@Shourya742

This comment was marked as outdated.

@GitGab19

This comment was marked as outdated.

@Shourya742

This comment was marked as outdated.

@plebhash

This comment was marked as outdated.

@Shourya742

This comment was marked as outdated.

@plebhash

This comment was marked as outdated.

@GitGab19

This comment was marked as outdated.

@plebhash

This comment was marked as outdated.

@GitGab19

This comment was marked as outdated.

@plebhash
Copy link
Collaborator

plebhash commented Jul 8, 2024

setting this as blocked since @GitGab19 and I realized our mental model was wrong and a lot of content on the discussions above was inaccurate

as a consequence, we unintentionally misled @Shourya742 in the wrong direction (apologies for that 🙏)

we are doing some calls to refine it, and we will post a refined visual diagram of the message flow here once we are confident about it

we also realized there is in fact a bug on the pool side, and we will write a new issue for it soon

@plebhash
Copy link
Collaborator

plebhash commented Jul 9, 2024

if this takes too much time, we should consider removing this from milestone 1.0.2

@plebhash
Copy link
Collaborator

plebhash commented Jul 12, 2024

@GitGab19 + @Shourya742 + @rrybarczyk + myself just finished a call where we refined a diagram for the message flow of this issue

#923 drawio

hopefully this will help @Shourya742 unblock his work here

@plebhash plebhash removed this from the 1.0.2 milestone Jul 15, 2024
@pavlenex pavlenex added this to the 1.0.3 milestone Jul 16, 2024
@plebhash plebhash linked a pull request Jul 29, 2024 that will close this issue
@pavlenex
Copy link
Collaborator

Should this one be dropped in favor of #1077 it seems there's already a WIP PR for it though @plebhash @Shourya742?

@Shourya742
Copy link
Contributor

Should this one be dropped in favor of #1077 it seems there's already a WIP PR for it though @plebhash @Shourya742?

@pavlenex , It makes sense to avoid writing MG tests for all these bug scenarios since integration tests will eventually cover them in a more reliable way. But getting the integration test suite to that level of maturity will take some time. We should keep these issues open, and as the test suite matures, we can add these scenarios to the test flows. Alternatively, we could take a test-driven development approach with the integration test suite—implementing features as needed to handle specific scenarios when they arise.

@plebhash plebhash removed this from the 1.0.3 milestone Aug 20, 2024
@rrybarczyk rrybarczyk removed a link to a pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress 🏗️
4 participants