-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MG test for false fallback activation #923
Comments
taking this up |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
setting this as blocked since @GitGab19 and I realized our mental model was wrong and a lot of content on the discussions above was inaccurate as a consequence, we unintentionally misled @Shourya742 in the wrong direction (apologies for that 🙏) we are doing some calls to refine it, and we will post a refined visual diagram of the message flow here once we are confident about it we also realized there is in fact a bug on the pool side, and we will write a new issue for it soon |
if this takes too much time, we should consider removing this from milestone 1.0.2 |
@GitGab19 + @Shourya742 + @rrybarczyk + myself just finished a call where we refined a diagram for the message flow of this issue hopefully this will help @Shourya742 unblock his work here |
Should this one be dropped in favor of #1077 it seems there's already a WIP PR for it though @plebhash @Shourya742? |
@pavlenex , It makes sense to avoid writing MG tests for all these bug scenarios since integration tests will eventually cover them in a more reliable way. But getting the integration test suite to that level of maturity will take some time. We should keep these issues open, and as the test suite matures, we can add these scenarios to the test flows. Alternatively, we could take a test-driven development approach with the integration test suite—implementing features as needed to handle specific scenarios when they arise. |
This is more a reminder for me than an issue, but I preferred to open an issue to better track it.
We need to add a MG test for specific scenario described in issue #901, addressing suggestions given under PR #904, that has been merged yesterday.
The text was updated successfully, but these errors were encountered: