Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust RELEASE.md #924

Merged
merged 1 commit into from
May 23, 2024
Merged

adjust RELEASE.md #924

merged 1 commit into from
May 23, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented May 22, 2024 •
edited
Loading

we recently had some issues where dev and main branches were diverging, which quickly snowballed into a big mess... that was a direct result of our previous branching strategy, which didn't take into consideration these potential issues

this PR makes some adjustments to the branching strategy described on RELEASE.md

with this adjustment to our branching strategy, we always merge to both feature and patch branches to dev.

main branch is only updated via PRs from dev

note: this is nothing different from what we've already been doing for weeks
this PR just aims to formalize this process under README.md

@github-actions GitHub Actions
Copy link
Contributor

🐰Bencher

ReportWed, May 22, 2024 at 22:34:32 UTC
ProjectStratum v2 (SRI)
Branchpatch-release-md
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,065.00 (+0.55%)2,133.98 (96.77%)✅ (view plot)473.00 (+0.49%)486.23 (97.28%)✅ (view plot)735.00 (+0.43%)754.56 (97.41%)✅ (view plot)7.00 (-3.75%)11.68 (59.95%)✅ (view plot)37.00 (+0.74%)38.67 (95.68%)
client_sv2_handle_message_mining✅ (view plot)8,203.00 (+0.01%)8,344.58 (98.30%)✅ (view plot)2,137.00 (+0.45%)2,171.21 (98.42%)✅ (view plot)3,163.00 (+0.59%)3,214.95 (98.38%)✅ (view plot)35.00 (-10.00%)43.37 (80.70%)✅ (view plot)139.00 (+0.04%)142.12 (97.81%)
client_sv2_mining_message_submit_standard✅ (view plot)6,242.00 (-0.59%)6,388.61 (97.71%)✅ (view plot)1,750.00 (+0.03%)1,763.03 (99.26%)✅ (view plot)2,557.00 (+0.14%)2,575.35 (99.29%)✅ (view plot)16.00 (-9.47%)22.61 (70.78%)✅ (view plot)103.00 (-0.89%)106.87 (96.38%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,825.00 (+0.23%)15,055.27 (98.47%)✅ (view plot)4,694.00 (+0.01%)4,707.03 (99.72%)✅ (view plot)6,755.00 (+0.02%)6,774.55 (99.71%)✅ (view plot)46.00 (-3.66%)52.81 (87.11%)✅ (view plot)224.00 (+0.54%)230.42 (97.21%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,560.00 (+0.22%)27,882.95 (98.84%)✅ (view plot)10,545.00 (+0.03%)10,558.44 (99.87%)✅ (view plot)15,340.00 (+0.01%)15,359.50 (99.87%)✅ (view plot)85.00 (+0.80%)90.49 (93.93%)✅ (view plot)337.00 (+0.47%)346.25 (97.33%)
client_sv2_open_channel✅ (view plot)4,527.00 (+0.68%)4,613.82 (98.12%)✅ (view plot)1,461.00 (+0.06%)1,474.29 (99.10%)✅ (view plot)2,152.00 (-0.02%)2,172.53 (99.06%)✅ (view plot)13.00 (+8.01%)15.34 (84.72%)✅ (view plot)66.00 (+1.14%)68.24 (96.72%)
client_sv2_open_channel_serialize✅ (view plot)14,266.00 (+0.23%)14,481.34 (98.51%)✅ (view plot)5,064.00 (+0.02%)5,077.29 (99.74%)✅ (view plot)7,316.00 (-0.02%)7,338.70 (99.69%)✅ (view plot)39.00 (+4.53%)41.76 (93.40%)✅ (view plot)193.00 (+0.37%)199.36 (96.81%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,708.00 (+0.19%)23,069.71 (98.43%)✅ (view plot)7,987.00 (+0.05%)8,001.01 (99.82%)✅ (view plot)11,613.00 (+0.01%)11,635.64 (99.81%)✅ (view plot)77.00 (+4.52%)82.43 (93.41%)✅ (view plot)306.00 (+0.24%)316.07 (96.81%)
client_sv2_setup_connection✅ (view plot)4,699.00 (-0.04%)4,764.58 (98.62%)✅ (view plot)1,502.00 (+0.06%)1,515.29 (99.12%)✅ (view plot)2,279.00 (+0.10%)2,299.40 (99.11%)✅ (view plot)8.00 (-11.65%)13.21 (60.54%)✅ (view plot)68.00 (+0.05%)69.57 (97.75%)
client_sv2_setup_connection_serialize✅ (view plot)16,368.00 (+0.58%)16,479.24 (99.32%)✅ (view plot)5,963.00 (+0.01%)5,976.29 (99.78%)✅ (view plot)8,653.00 (-0.02%)8,677.04 (99.72%)✅ (view plot)45.00 (+0.69%)49.19 (91.48%)✅ (view plot)214.00 (+1.27%)217.05 (98.59%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,596.00 (+0.14%)35,767.18 (99.52%)✅ (view plot)14,814.00 (+0.03%)14,828.01 (99.91%)✅ (view plot)21,751.00 (+0.01%)21,771.67 (99.91%)✅ (view plot)102.00 (+1.70%)114.37 (89.18%)✅ (view plot)381.00 (+0.29%)384.65 (99.05%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

🐰Bencher

ReportWed, May 22, 2024 at 22:34:32 UTC
ProjectStratum v2 (SRI)
Branch924/merge
Testbedsv1

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client-sv1-authorize-serialize/client-sv1-authorize-serializeLatency (nanoseconds (ns))🚨 (view plot | view alert)255.65 (+3.04%)255.13 (100.20%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,966.60 (+0.56%)7,282.41 (95.66%)
client-submit-serialize-deserialize✅ (view plot)7,613.70 (-2.87%)8,270.98 (92.05%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,399.50 (-0.26%)8,824.77 (95.18%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)890.04 (-0.91%)926.94 (96.02%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)690.44 (-0.90%)718.05 (96.16%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize🚨 (view plot | view alert)255.65 (+3.04%)255.13 (100.20%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)157.56 (+0.46%)160.14 (98.39%)
client-sv1-get-submit✅ (view plot)6,862.30 (+2.57%)7,048.29 (97.36%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)284.32 (+1.94%)291.79 (97.44%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)754.06 (+0.90%)776.83 (97.07%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)629.09 (+2.27%)638.90 (98.47%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)207.82 (+0.52%)220.25 (94.36%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

🐰Bencher

ReportWed, May 22, 2024 at 22:34:32 UTC
ProjectStratum v2 (SRI)
Branchpatch-release-md
Testbedsv2

🚨 4 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonLatency (nanoseconds (ns))🚨 (view plot | view alert)45.85 (+2.89%)45.31 (101.20%)
client_sv2_mining_message_submit_standardLatency (nanoseconds (ns))🚨 (view plot | view alert)15.21 (+3.73%)14.82 (102.61%)
client_sv2_mining_message_submit_standard_serialize_deserializeLatency (nanoseconds (ns))🚨 (view plot | view alert)634.72 (+6.80%)627.14 (101.21%)
client_sv2_open_channelLatency (nanoseconds (ns))🚨 (view plot | view alert)182.41 (+9.96%)173.41 (105.19%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common🚨 (view plot | view alert)45.85 (+2.89%)45.31 (101.20%)
client_sv2_handle_message_mining✅ (view plot)77.41 (+5.17%)83.72 (92.46%)
client_sv2_mining_message_submit_standard🚨 (view plot | view alert)15.21 (+3.73%)14.82 (102.61%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)280.07 (+5.70%)284.18 (98.55%)
client_sv2_mining_message_submit_standard_serialize_deserialize🚨 (view plot | view alert)634.72 (+6.80%)627.14 (101.21%)
client_sv2_open_channel🚨 (view plot | view alert)182.41 (+9.96%)173.41 (105.19%)
client_sv2_open_channel_serialize✅ (view plot)291.20 (+2.22%)296.29 (98.28%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)391.96 (+4.16%)401.89 (97.53%)
client_sv2_setup_connection✅ (view plot)171.70 (+4.51%)175.27 (97.97%)
client_sv2_setup_connection_serialize✅ (view plot)489.96 (+3.25%)500.31 (97.93%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)1,026.00 (+5.80%)1,041.73 (98.49%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

🐰Bencher

ReportWed, May 22, 2024 at 22:34:32 UTC
ProjectStratum v2 (SRI)
Branchpatch-release-md
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,478.00 (+0.64%)8,704.41 (97.40%)✅ (view plot)3,746.00 (+0.25%)3,848.97 (97.32%)✅ (view plot)5,248.00 (+0.18%)5,389.88 (97.37%)✅ (view plot)9.00 (+10.24%)10.50 (85.75%)✅ (view plot)91.00 (+1.27%)93.69 (97.13%)
get_submit✅ (view plot)95,575.00 (+0.03%)96,131.97 (99.42%)✅ (view plot)59,439.00 (-0.03%)59,764.80 (99.45%)✅ (view plot)85,350.00 (-0.04%)85,811.38 (99.46%)✅ (view plot)57.00 (+2.69%)62.69 (90.93%)✅ (view plot)284.00 (+0.56%)288.05 (98.60%)
get_subscribe✅ (view plot)8,041.00 (+0.80%)8,270.25 (97.23%)✅ (view plot)2,841.00 (+0.43%)2,938.49 (96.68%)✅ (view plot)3,966.00 (+0.36%)4,096.65 (96.81%)✅ (view plot)17.00 (+3.89%)19.80 (85.85%)✅ (view plot)114.00 (+1.18%)116.98 (97.45%)
serialize_authorize✅ (view plot)12,197.00 (+0.13%)12,451.78 (97.95%)✅ (view plot)5,317.00 (+0.18%)5,419.97 (98.10%)✅ (view plot)7,412.00 (+0.14%)7,553.91 (98.12%)✅ (view plot)12.00 (+7.84%)13.64 (88.01%)✅ (view plot)135.00 (+0.03%)138.96 (97.15%)
serialize_deserialize_authorize✅ (view plot)24,476.00 (+0.11%)24,668.76 (99.22%)✅ (view plot)9,898.00 (+0.06%)10,011.64 (98.86%)✅ (view plot)13,956.00 (+0.02%)14,123.99 (98.81%)✅ (view plot)39.00 (+4.84%)41.89 (93.11%)✅ (view plot)295.00 (+0.14%)297.14 (99.28%)
serialize_deserialize_handle_authorize✅ (view plot)30,207.00 (+0.22%)30,327.46 (99.60%)✅ (view plot)12,101.00 (+0.08%)12,203.97 (99.16%)✅ (view plot)17,117.00 (+0.04%)17,268.86 (99.12%)✅ (view plot)63.00 (+7.04%)65.17 (96.67%)✅ (view plot)365.00 (+0.30%)366.63 (99.55%)
serialize_deserialize_handle_submit✅ (view plot)126,468.00 (+0.05%)127,026.11 (99.56%)✅ (view plot)73,224.00 (-0.02%)73,606.42 (99.48%)✅ (view plot)104,938.00 (-0.03%)105,486.36 (99.48%)✅ (view plot)127.00 (+4.74%)133.23 (95.32%)✅ (view plot)597.00 (+0.30%)599.42 (99.60%)
serialize_deserialize_handle_subscribe✅ (view plot)27,535.00 (+0.27%)27,609.42 (99.73%)✅ (view plot)9,643.00 (+0.13%)9,740.49 (99.00%)✅ (view plot)13,630.00 (+0.07%)13,773.00 (98.96%)✅ (view plot)72.00 (+9.57%)72.37 (99.49%)✅ (view plot)387.00 (+0.25%)388.44 (99.63%)
serialize_deserialize_submit✅ (view plot)115,065.00 (+0.01%)115,601.83 (99.54%)✅ (view plot)68,001.00 (-0.05%)68,367.89 (99.46%)✅ (view plot)97,550.00 (-0.06%)98,087.56 (99.45%)✅ (view plot)73.00 (+4.86%)75.41 (96.80%)✅ (view plot)490.00 (+0.34%)492.65 (99.46%)
serialize_deserialize_subscribe✅ (view plot)22,912.00 (+0.20%)23,094.68 (99.21%)✅ (view plot)8,195.00 (+0.14%)8,294.47 (98.80%)✅ (view plot)11,537.00 (+0.10%)11,676.84 (98.80%)✅ (view plot)42.00 (+5.87%)44.41 (94.58%)✅ (view plot)319.00 (+0.21%)321.13 (99.34%)
serialize_submit✅ (view plot)99,858.00 (-0.01%)100,437.15 (99.42%)✅ (view plot)61,483.00 (-0.03%)61,814.35 (99.46%)✅ (view plot)88,198.00 (-0.04%)88,666.07 (99.47%)✅ (view plot)57.00 (+1.85%)61.72 (92.35%)✅ (view plot)325.00 (+0.13%)329.01 (98.78%)
serialize_subscribe✅ (view plot)11,336.00 (+0.21%)11,576.19 (97.93%)✅ (view plot)4,188.00 (+0.29%)4,285.49 (97.73%)✅ (view plot)5,826.00 (+0.27%)5,956.61 (97.81%)✅ (view plot)17.00 (+2.97%)19.17 (88.69%)✅ (view plot)155.00 (+0.11%)158.88 (97.55%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@GitGab19 GitGab19 merged commit c8424b6 into stratum-mining:dev May 23, 2024
13 checks passed
@plebhash plebhash deleted the patch-release-md branch May 23, 2024 13:46
@plebhash plebhash mentioned this pull request May 23, 2024
Merged
Fi3 pushed a commit that referenced this pull request May 28, 2024
@plebhash @Fi3
patch RELEASE.md (#924)
24cea91
@plebhash plebhash mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fi3 Fi3 Fi3 approved these changes

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plebhash @Fi3 @GitGab19