STREAM-1060: check all token accounts ATA #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yolley
changed the title
Yolley
commented
Dec 26, 2023
Yolley
changed the title
| return; | ||
| } | ||
| const checkedKeys: Set<PublicKey> = new Set(); | ||
| const accountArrays = [ |
There was a problem hiding this comment.
Let's create a proper object out of this?
We could just have a type and cast data to it.
Much easier then to work with indexes
There was a problem hiding this comment.
What do you mean here? Seems complex.
There was a problem hiding this comment.
It's easier to read then associating [1] to senderTokens for instance.
| const response = await this.connection.getMultipleAccountsInfo( | ||
| accountArrays.map((item) => item[1]) | ||
| ); | ||
| for (let i = 0; i < response.length; i++) { |
There was a problem hiding this comment.
Can we iterate here over accountArrays in forof loop?
for accountArray of accountArrays ...
There was a problem hiding this comment.
More clean then traditional for loop with indexes :)
There was a problem hiding this comment.
I need it here because every index in response corresponds to index in accountArrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.