Skip to content

Commit

Permalink
Merge pull request ethereum#227 from binance-chain/cache_write_policy
Browse files Browse the repository at this point in the history
[R4R]use more aggressive write cache policy
  • Loading branch information
unclezoro authored May 24, 2021
2 parents 032970b + 571a317 commit b67a129
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion consensus/parlia/parlia.go
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ func (p *Parlia) EnoughDistance(chain consensus.ChainReader, header *types.Heade
if err != nil {
return true
}
return snap.enoughDistance(p.val)
return snap.enoughDistance(p.val, header)
}

// CalcDifficulty is the difficulty adjustment algorithm. It returns the difficulty
Expand Down
12 changes: 9 additions & 3 deletions consensus/parlia/snapshot.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,17 +244,23 @@ func (s *Snapshot) inturn(validator common.Address) bool {
return validators[offset] == validator
}

func (s *Snapshot) enoughDistance(validator common.Address) bool {
func (s *Snapshot) enoughDistance(validator common.Address, header *types.Header) bool {
idx := s.indexOfVal(validator)
if idx < 0 {
return true
}
validatorNum := int64(len(s.validators()))
if validatorNum == 1 {
return true
}
if validator == header.Coinbase {
return false
}
offset := (int64(s.Number) + 1) % int64(validatorNum)
if int64(idx) >= offset {
return int64(idx)-offset >= validatorNum/2
return int64(idx)-offset >= validatorNum-2
} else {
return validatorNum+int64(idx)-offset >= validatorNum/2
return validatorNum+int64(idx)-offset >= validatorNum-2
}
}

Expand Down
3 changes: 3 additions & 0 deletions eth/backend.go
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,9 @@ func (s *Ethereum) Stop() error {
close(s.closeBloomHandler)
s.txPool.Stop()
s.miner.Stop()
s.miner.Close()
// TODO this is a hotfix for https://github.com/ethereum/go-ethereum/issues/22892, need a better solution
time.Sleep(5 * time.Second)
s.blockchain.Stop()
s.engine.Close()
rawdb.PopUncleanShutdownMarker(s.chainDb)
Expand Down

0 comments on commit b67a129

Please sign in to comment.