cli: fix pluginerror in handle_url if json is True #4590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4589
console.exit(msg)
requires astr
parameter, otherwise it'll try to serialize the unknown input type as JSON ifargs.json
is True, which can fail:streamlink/src/streamlink_cli/console.py
Lines 89 to 95 in 2a5b71f
As already said in other threads, the ConsoleOutput usage and handling of console.exit() is pretty bad and needs to be rewritten.