Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rephrase and clarify plugin rules #5949

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

bastimeyer
Copy link
Member

See #5904
Follow-up of #5947

This doesn't update any of the current plugin rules and just rephrases and clarifies them.

Copy link
Member

@gravyboat gravyboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good changes. I've added a minor suggestion and brought up one point around content which could put us in a sticky spot regarding which might allow people to start asking for their local TV station websites again. Take or leave whatever makes sense to you.

CONTRIBUTING.md Outdated Show resolved Hide resolved

10. Sites which have no way to determine viewership numbers
Plugins must only support websites with authentic content.
Copy link
Member

@gravyboat gravyboat Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we defining "authentic" here? This was an annoying spot we got in to in the past when people asked us to implement some weird TV station that was running news broadcasts or other local content. Does this need to be more explicit? I don't think a nightly news broadcast for a town or village of 200 people really counts as authentic or non-niche.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you're confusing two rules here. Niche content is already covered by rule 10.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I'm aware of rule 10 but my assumption is most people aren't going to read all the rules so I'm not sure if we should be more explicit in this one. It's not a major deal or anything, I just don't want the headache of arguing with people about what the word "authentic" means so I figured I'd mention it. We can revise later if it becomes a problem.


5. **NSFW sites of a pornographic nature**

This also includes borderline NSFW content, as it lowers the bar for follow-up plugin requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good addition to note here regarding borderline content.

@bastimeyer bastimeyer merged commit 7a4a290 into streamlink:master Apr 18, 2024
23 checks passed
@bastimeyer bastimeyer deleted the docs/rephrase-plugin-rules branch April 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants