Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: log sha256 of overriding plugin module #6023

Merged

Conversation

bastimeyer
Copy link
Member

No description provided.

@gravyboat
Copy link
Member

Is there an issue attached to this? What is it needed for?

@bastimeyer
Copy link
Member Author

I want to be sure that when users sideload plugins when providing PR feedback that the plugin is indeed sideloaded correctly. The added SHA256 checksum in the log message will confirm that.

Copy link
Member

@gravyboat gravyboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sounds good, approved.

@bastimeyer bastimeyer merged commit ad6dafe into streamlink:master Jun 7, 2024
23 checks passed
@bastimeyer bastimeyer deleted the session/plugin-override-hash branch June 7, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants