This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Create cluster if it doesn't exist during metadata initialisation #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case is usually encountered when attempting to use KoP with standalone mode. When new behavior was introduced in streamnative#168 standalone mode was broken due to sample namespace setup etc not taking place until after the broker is initalised (which in turn initialises protocol handlers). Fixes streamnative#185
josephglanville
force-pushed
the
jpg/create-cluster-metadata-init
branch
from
cd8afd3
to
a9356b3
Compare
|
I see in numerous places references to TLS not being supported, is that relevant here when constructing the cluster data? |
|
Thanks for your contribution! The standalone problem has existed for a long time and I nearly forgot to look into the issue. BTW, recently schemaRegistryTest and Kafka Streams related tests were not stable in github CI. I think we can merge this PR even if they failed.
IMO it's not. The cluster metadata is used for Pulsar not KoP. And if you didn't configure TLS related metadata, it wouldn't be written to Z-node. |
BewareMyPower
approved these changes
Apr 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case is usually encountered when attempting to use KoP with
standalone mode. When new behavior was introduced in #168 standalone
mode was broken due to sample namespace setup etc not taking place until
after the broker is initalised (which in turn initialises protocol
handlers).
Fixes #185