Using retryable operation to replace sleep to make tests stable #544

zymap · 2021-12-29T07:43:06Z

Motivation

Using RunFuncWithTimeout to replace sleep operation to make
the tests are stable.

This PR is based on #541 , so please merge #641 at first.

--- *Motivation* Using `RunFuncWithTimeout` to replace sleep operation to make the tests stable.

nodece · 2021-12-30T08:32:17Z

@zymap Could you fix this CI and conflicts?

zymap · 2021-12-31T00:30:10Z

There are three tests still failed:

--- FAIL: TestDeleteNonExistingTopicSub (30.01s)
    delete_test.go:92: 
        	Error Trace:	delete_test.go:92
        	Error:      	Not equal: 
        	            	expected: "code: 404 reason: Topic not found"
        	            	actual  : "code: 500 reason: \n --- An unexpected error occurred in the server ---\n\nMessage: null\n\nStacktrace:\n\njava.lang.NullPointerException\n\tat org.apache.pulsar.broker.web.RestException.getExceptionData(RestException.java:44)\n\tat org.apache.pulsar.broker.web.RestException.getResponse(RestException.java:81)\n\tat org.apache.pulsar.broker.web.RestException.<init>(RestException.java:57)\n\tat org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.getTopicReference(PersistentTopicsBase.java:3643)\n\tat org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.internalDeleteSubscriptionForNonPartitionedTopic(PersistentTopicsBase.java:1492)\n\tat org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalDeleteSubscription$77(PersistentTopicsBase.java:1475)\n\tat java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714)\n\tat java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)\n\tat java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073)\n\tat org.apache.pulsar.metadata.impl.ZKMetadataStore.lambda$null$7(ZKMetadataStore.java:158)\n\tat java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)\n\tat java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)\n\tat io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat java.base/java.lang.Thread.run(Thread.java:829)\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1,23 @@
        	            	-code: 404 reason: Topic not found
        	            	+code: 500 reason: 
        	            	+ --- An unexpected error occurred in the server ---
        	            	+
        	            	+Message: null
        	            	+
        	            	+Stacktrace:
        	            	+
        	            	+java.lang.NullPointerException
        	            	+	at org.apache.pulsar.broker.web.RestException.getExceptionData(RestException.java:44)
        	            	+	at org.apache.pulsar.broker.web.RestException.getResponse(RestException.java:81)
        	            	+	at org.apache.pulsar.broker.web.RestException.<init>(RestException.java:57)
        	            	+	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.getTopicReference(PersistentTopicsBase.java:3643)
        	            	+	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.internalDeleteSubscriptionForNonPartitionedTopic(PersistentTopicsBase.java:1492)
        	            	+	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalDeleteSubscription$77(PersistentTopicsBase.java:1475)
        	            	+	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714)
        	            	+	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)
        	            	+	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073)
        	            	+	at org.apache.pulsar.metadata.impl.ZKMetadataStore.lambda$null$7(ZKMetadataStore.java:158)
        	            	+	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        	            	+	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        	            	+	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        	            	+	at java.base/java.lang.Thread.run(Thread.java:829)
        	            	+
        	Test:       	TestDeleteNonExistingTopicSub


--- FAIL: TestResetCursorNonExistingTopic (30.00s)
    reset_cursor_test.go:63: 
        	Error Trace:	reset_cursor_test.go:63
        	Error:      	Not equal: 
        	            	expected: "code: 404 reason: Topic not found"
        	            	actual  : "code: 500 reason: \n --- An unexpected error occurred in the server ---\n\nMessage: null\n\nStacktrace:\n\njava.lang.NullPointerException\n\tat org.apache.pulsar.broker.web.RestException.getExceptionData(RestException.java:44)\n\tat org.apache.pulsar.broker.web.RestException.getResponse(RestException.java:81)\n\tat org.apache.pulsar.broker.web.RestException.<init>(RestException.java:57)\n\tat org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.getTopicReference(PersistentTopicsBase.java:3643)\n\tat org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.internalResetCursorForNonPartitionedTopic(PersistentTopicsBase.java:1996)\n\tat org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalResetCursor$93(PersistentTopicsBase.java:1976)\n\tat java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714)\n\tat java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)\n\tat java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073)\n\tat org.apache.pulsar.metadata.impl.ZKMetadataStore.lambda$null$7(ZKMetadataStore.java:158)\n\tat java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)\n\tat java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)\n\tat io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat java.base/java.lang.Thread.run(Thread.java:829)\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1,23 @@
        	            	-code: 404 reason: Topic not found
        	            	+code: 500 reason: 
        	            	+ --- An unexpected error occurred in the server ---
        	            	+
        	            	+Message: null
        	            	+
        	            	+Stacktrace:
        	            	+
        	            	+java.lang.NullPointerException
        	            	+	at org.apache.pulsar.broker.web.RestException.getExceptionData(RestException.java:44)
        	            	+	at org.apache.pulsar.broker.web.RestException.getResponse(RestException.java:81)
        	            	+	at org.apache.pulsar.broker.web.RestException.<init>(RestException.java:57)
        	            	+	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.getTopicReference(PersistentTopicsBase.java:3643)
        	            	+	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.internalResetCursorForNonPartitionedTopic(PersistentTopicsBase.java:1996)
        	            	+	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalResetCursor$93(PersistentTopicsBase.java:1976)
        	            	+	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714)
        	            	+	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)
        	            	+	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073)
        	            	+	at org.apache.pulsar.metadata.impl.ZKMetadataStore.lambda$null$7(ZKMetadataStore.java:158)
        	            	+	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        	            	+	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        	            	+	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        	            	+	at java.base/java.lang.Thread.run(Thread.java:829)
        	            	+
        	Test:       	TestResetCursorNonExistingTopic

--- FAIL: TestCompactNonExistingTopic (30.02s)
    compact_test.go:60: 
        	Error Trace:	compact_test.go:60
        	Error:      	Not equal: 
        	            	expected: "code: 404 reason: Topic not found"
        	            	actual  : "code: 500 reason: \n --- An unexpected error occurred in the server ---\n\nMessage: null\n\nStacktrace:\n\njava.lang.NullPointerException\n\tat org.apache.pulsar.broker.web.RestException.getExceptionData(RestException.java:44)\n\tat org.apache.pulsar.broker.web.RestException.getResponse(RestException.java:81)\n\tat org.apache.pulsar.broker.web.RestException.<init>(RestException.java:57)\n\tat org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.getTopicReference(PersistentTopicsBase.java:3643)\n\tat org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.internalTriggerCompactionNonPartitionedTopic(PersistentTopicsBase.java:3513)\n\tat org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalTriggerCompaction$156(PersistentTopicsBase.java:3493)\n\tat java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714)\n\tat java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)\n\tat java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073)\n\tat org.apache.pulsar.metadata.impl.ZKMetadataStore.lambda$null$7(ZKMetadataStore.java:158)\n\tat java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)\n\tat java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)\n\tat io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat java.base/java.lang.Thread.run(Thread.java:829)\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1,23 @@
        	            	-code: 404 reason: Topic not found
        	            	+code: 500 reason: 
        	            	+ --- An unexpected error occurred in the server ---
        	            	+
        	            	+Message: null
        	            	+
        	            	+Stacktrace:
        	            	+
        	            	+java.lang.NullPointerException
        	            	+	at org.apache.pulsar.broker.web.RestException.getExceptionData(RestException.java:44)
        	            	+	at org.apache.pulsar.broker.web.RestException.getResponse(RestException.java:81)
        	            	+	at org.apache.pulsar.broker.web.RestException.<init>(RestException.java:57)
        	            	+	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.getTopicReference(PersistentTopicsBase.java:3643)
        	            	+	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.internalTriggerCompactionNonPartitionedTopic(PersistentTopicsBase.java:3513)
        	            	+	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalTriggerCompaction$156(PersistentTopicsBase.java:3493)
        	            	+	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714)
        	            	+	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)
        	            	+	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073)
        	            	+	at org.apache.pulsar.metadata.impl.ZKMetadataStore.lambda$null$7(ZKMetadataStore.java:158)
        	            	+	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        	            	+	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        	            	+	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        	            	+	at java.base/java.lang.Thread.run(Thread.java:829)
        	            	+
        	Test:       	TestCompactNonExistingTopic

zymap · 2021-12-31T00:32:34Z

They are fixing at pulsar side: apache/pulsar#13551

zymap · 2022-01-21T05:58:11Z

Same fix with #555, close this PR

zymap added 5 commits December 29, 2021 12:04

Update the master branch image version

0a6d5c2

Allow retry the operationt to avoid test failure

7e68c09

Add retry for the failure case

b1ab4f0

Allow retry the operationt to avoid test failure

aca5a41

Using retryable operation to replace sleep to make tests stable

140aeca

--- *Motivation* Using `RunFuncWithTimeout` to replace sleep operation to make the tests stable.

zymap self-assigned this Dec 29, 2021

zymap requested a review from a team as a code owner December 29, 2021 07:43

Merge branch 'master' into retry-tests

7c90238

mattisonchao mentioned this pull request Dec 31, 2021

NPE when reset-cursor at a non-existent topic apache/pulsar#13551

Closed

zymap closed this Jan 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using retryable operation to replace sleep to make tests stable #544

Using retryable operation to replace sleep to make tests stable #544

zymap commented Dec 29, 2021

nodece commented Dec 30, 2021

zymap commented Dec 31, 2021

zymap commented Dec 31, 2021

zymap commented Jan 21, 2022

Using retryable operation to replace sleep to make tests stable #544

Using retryable operation to replace sleep to make tests stable #544

Conversation

zymap commented Dec 29, 2021

nodece commented Dec 30, 2021

zymap commented Dec 31, 2021

zymap commented Dec 31, 2021

zymap commented Jan 21, 2022