Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "sign allows cycling on sidewalk, both directions" option to cycleway quest/overlay #5931

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

wielandb
Copy link
Contributor

@wielandb wielandb commented Sep 27, 2024

Adds the option "None, but sign allows cycling on sidewalk, both directions" to the available road-side cycleway options.

photo_2024-10-13_19-59-21

Fixes #5888

@kmpoppe
Copy link
Collaborator

kmpoppe commented Sep 27, 2024

Using svgomg, the svg could get 48% smaller, (2.89k -> 1.39k) do you want to update the picture?

@westnordost
Copy link
Member

westnordost commented Oct 2, 2024

Inkscape can do that too. Just save the SVG as "Optimized SVG". I always do that, I don't care for all that stuff Inkscape adds to the file to save the "session".

@wielandb
Copy link
Contributor Author

I saved the svg as "Optimized SVG". For me, it reduced the size from 10kB to 8kB.

@wielandb wielandb marked this pull request as ready for review October 13, 2024 18:00
@wielandb
Copy link
Contributor Author

I used svgomg on the already optimized svg and it reduced the file size a bit further. :)

@wielandb
Copy link
Contributor Author

Implemented feature + tests. Tests work and used it myself a bit. Should be ready for review now.

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

app/src/main/res/values/strings.xml Show resolved Hide resolved
app/src/main/res/drawable/sidewalk_ok_dual.xml Outdated Show resolved Hide resolved
@westnordost westnordost merged commit f9f5528 into streetcomplete:master Oct 15, 2024
@FloEdelmann
Copy link
Member

@wielandb There is a failed test now:

de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest > apply allowed on sidewalk with both directions to both sides FAILED

https://github.com/streetcomplete/StreetComplete/actions/runs/11347572803/job/31559284851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cycling on sidewalk (in both directions) answer is missing
4 participants