-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "sign allows cycling on sidewalk, both directions" option to cycleway quest/overlay #5931
Add "sign allows cycling on sidewalk, both directions" option to cycleway quest/overlay #5931
Conversation
Using svgomg, the svg could get 48% smaller, (2.89k -> 1.39k) do you want to update the picture? |
Inkscape can do that too. Just save the SVG as "Optimized SVG". I always do that, I don't care for all that stuff Inkscape adds to the file to save the "session". |
I saved the svg as "Optimized SVG". For me, it reduced the size from 10kB to 8kB. |
I used svgomg on the already optimized svg and it reduced the file size a bit further. :) |
Implemented feature + tests. Tests work and used it myself a bit. Should be ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good!
@wielandb There is a failed test now:
https://github.com/streetcomplete/StreetComplete/actions/runs/11347572803/job/31559284851 |
Adds the option "None, but sign allows cycling on sidewalk, both directions" to the available road-side cycleway options.
Fixes #5888