-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With version 5 upgrade, suggestions are very limited for short words #753
Comments
Thank you for the bug report. |
Here are a few I could come up with. I would test using "Code Spell Checker" to give you something that would be 100% reproducible on your end, but it looks like that doesn't use v5 yet. We are not using the exact same english dictionary but the problem should still manifest: Thanks! |
Than you! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Info
Kind of Issue
Which Tool or library
Which Version
Version: 5.0.6
Issue with supporting library?
OS:
Bug Description
Before upgrading to version 5, our suggestions for "Im" would include "I'm", now we get no suggestions
To Reproduce
Looking at the code, I think it's generally reproducible, but we don't use the cli.
Expected behavior
Should get more suggestions for short words
Additional context
Looks like suggestions are getting filtered out by
let maxCost: number = Math.min((baseCost * wordToMatch.length) / 2, baseCost * changeLimit);
where the
(baseCost * wordToMatch.length) / 2
relies on constants user code doesn't have access to. My understanding is far from perfect, but it seems like post upgrade the cost for an insertion exceeds this threshold for a 2 letter words.Thanks! I love this library!
The text was updated successfully, but these errors were encountered: