Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we update to newer jinja2? #622

Closed
lochsh opened this issue Feb 24, 2022 · 4 comments
Closed

Can we update to newer jinja2? #622

lochsh opened this issue Feb 24, 2022 · 4 comments

Comments

@lochsh
Copy link
Contributor

lochsh commented Feb 24, 2022

The pyproject.toml specifies jinja2 = "^2.11.2" for jinja2. There's now a new major version of jinja2, and the tests pass if I upgrade strictdoc to it. Might it make sense to upgrade?

My own personal motivation for this is wanting to use this with a project that requires jinja2 = "^3.0.3" but also uses strictdoc. I am not saying that this is motivation for the strictdoc project to change, but it seems like it makes sense to move to a more up to date version if it still meets the project's needs.

I can fix my own personal problem in other ways if not.

@lochsh
Copy link
Contributor Author

lochsh commented Feb 24, 2022

It turns out the new release of Jinja2 has caused problems for people, see this issue pallets/jinja#1585 (comment)

Basically, Jinja2 v2 is now end-of-life/unsupported. When they specify their dependencies, they only specify a minimum version, not a maximum. But Jinja2 v2.11 is not compatible with newer versions of markupsafe. The maintainers don't want to change it as it's no longer supported.

Anyway -- perhaps strictdoc's pyproject.toml could say `jinja2 = ">=2.11.2,<4.0"?

@stanislaw
Copy link
Collaborator

stanislaw commented Feb 24, 2022

@lochsh we can certainly relax the pyproject.toml's requirement. Could you suggest a Pull Request? If yes, in addition to adding the necessary change to the toml file, please also run this command locally: invoke export-pip-requirements - it makes Poetry to generate the requirements.txt file that is used by the Windows CI.

@lochsh
Copy link
Contributor Author

lochsh commented Feb 24, 2022

I'll do so now :)

I noticed the version in the pyproject.toml is 0.0.11, should it be 0.0.19?

Apologies, my checkout was stale!

lochsh added a commit to lochsh/strictdoc that referenced this issue Feb 24, 2022
lochsh added a commit to lochsh/strictdoc that referenced this issue Feb 24, 2022
@stanislaw
Copy link
Collaborator

The new package 0.0.20 has been released. Thank you for your feedback and contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants