Fix offset.show-all switch in Kafka Exporter
#10022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <[email protected]>
im-konge
approved these changes
Apr 24, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Apr 24, 2024
ppatierno
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The
offset.show-allswitch from #9494 does not work because it is enabled by default in Kafka Exporter. So we need to disable it when it is disabled in the Kafka CR. But today, we just enable it when it is enabled in Kafka CR, so as a result it is always on. This PR flips the condition to disable it in Kafka Exporter when set to false.Checklist