Fixed stuck reconciliation on failed request rebalance #10717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR fixes #10631.
What's happening right now is that after issuing a proposal request again (when the user task doesn't exist, i.e. CC rolled), we are not handling the failure (in this case the "brokers to be removed don't exist anymore", they were already scaled) so the lock on the
KafkaRebalance
is never released and the reconciliation on it never ends (a failure log shows a never ending "Reconciliation in progress" every periodic timer call).This fix handles the failure scenario allowing the
KafkaRebalance
to move inNotReady
state which means:KafkaRebalance
which is not needed anymore because the rebalancing was done and nodes scaled down.Checklist