Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stuck reconciliation on failed request rebalance #10717

Merged

Conversation

ppatierno
Copy link
Member

Type of change

  • Bugfix

Description

This PR fixes #10631.

What's happening right now is that after issuing a proposal request again (when the user task doesn't exist, i.e. CC rolled), we are not handling the failure (in this case the "brokers to be removed don't exist anymore", they were already scaled) so the lock on the KafkaRebalance is never released and the reconciliation on it never ends (a failure log shows a never ending "Reconciliation in progress" every periodic timer call).
This fix handles the failure scenario allowing the KafkaRebalance to move in NotReady state which means:

  • for a manual rebalance, providing the user a way to understand what happened and behave accordingly
  • for auto-rebalancing, deleting the KafkaRebalance which is not needed anymore because the rebalancing was done and nodes scaled down.

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging

@ppatierno ppatierno added this to the 0.44.0 milestone Oct 15, 2024
@ppatierno
Copy link
Member Author

This PR was also tested through the @see-quick STs which were failing exactly on this #10666

@ppatierno
Copy link
Member Author

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ppatierno ppatierno merged commit c370491 into strimzi:main Oct 15, 2024
21 checks passed
@ppatierno ppatierno deleted the fix-locked-kafkarebalance-reconciliation branch October 15, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove-brokers rebalancing seems to get stuck by race condition
3 participants