Handle the failure due to reaching the servlet capacity when getting user tasks #10768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user tasks Signed-off-by: Gantigmaa Selenge <[email protected]>
tinaselenge
force-pushed
the
issue#10704
branch
from
230e789
to
1b0ff08
Compare
|
/azp run build |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Gantigmaa Selenge <[email protected]>
tinaselenge
force-pushed
the
issue#10704
branch
from
f6e9311
to
3dd12c9
Compare
katheris
approved these changes
Oct 31, 2024
| */ | ||
| CruiseControlUserTasksResponse(String userTaskId, JsonObject json) { | ||
| super(userTaskId, json); | ||
| // The maximum number of active user tasks that can run concurrently has reached |
There was a problem hiding this comment.
Should this comment be on the isMaxActiveUserTasksReached variable?
| * Response to user tasks request | ||
| */ | ||
| public class CruiseControlUserTasksResponse extends CruiseControlResponse { | ||
| private boolean isMaxActiveUserTasksReached; |
There was a problem hiding this comment.
Suggested change
| private boolean isMaxActiveUserTasksReached; | |
| private boolean maxActiveUserTasksReached; |
| Promise<MapAndStatus<ConfigMap, KafkaRebalanceStatus>> p, String sessionId, | ||
| Set<Condition> conditions, KafkaRebalance kafkaRebalance, | ||
| ConfigMapOperator configMapOperator, boolean dryRun, | ||
| String host, CruiseControlApi apiClient, | ||
| AbstractRebalanceOptions.AbstractRebalanceOptionsBuilder<?, ?> rebalanceOptionsBuilder) { | ||
| if (cruiseControlResponse.isMaxActiveUserTasksReached()) { | ||
| LOGGER.warnCr(reconciliation, "The maximum number of active user tasks that can run concurrently has reached therefore will retry getting user tasks in the next reconciliation. " + |
There was a problem hiding this comment.
Suggested change
| LOGGER.warnCr(reconciliation, "The maximum number of active user tasks that can run concurrently has reached therefore will retry getting user tasks in the next reconciliation. " + | |
| LOGGER.warnCr(reconciliation, "The maximum number of active user tasks that Cruise Control can run concurrently has been reached, therefore will retry getting user tasks in the next reconciliation. " + |
| Promise<MapAndStatus<ConfigMap, KafkaRebalanceStatus>> p, String sessionId, | ||
| Set<Condition> conditions, KafkaRebalance kafkaRebalance, | ||
| ConfigMapOperator configMapOperator, boolean dryRun, | ||
| String host, CruiseControlApi apiClient, | ||
| AbstractRebalanceOptions.AbstractRebalanceOptionsBuilder<?, ?> rebalanceOptionsBuilder) { | ||
| if (cruiseControlResponse.isMaxActiveUserTasksReached()) { | ||
| LOGGER.warnCr(reconciliation, "The maximum number of active user tasks that can run concurrently has reached therefore will retry getting user tasks in the next reconciliation. " + | ||
| "If this occurs often, consider increasing the value for max.active.user.tasks configuration."); |
There was a problem hiding this comment.
Suggested change
| "If this occurs often, consider increasing the value for max.active.user.tasks configuration."); | |
| "If this occurs often, consider increasing the value for max.active.user.tasks in the Cruise Control configuration."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
If failed to get user tasks due to reaching the servlet capacity, it will no longer transition the KafkaRebalance status to NotReady. Instead, KafkaRebalance status will not be changed and in the next reconciliation, it will retry getting the user tasks again. The operator will also report a warning message.
Resolves #10704
Checklist
Please go through this checklist and make sure all applicable tasks have been done