Add current roles to the node pool status #9458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <[email protected]>
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Dec 13, 2023
api/src/main/java/io/strimzi/api/kafka/model/nodepool/KafkaNodePoolStatus.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR adds a new field
rolesto thestatus of theKafkaNodePool` resource which is used to track the roles assigned to given node pool. This field is also set as part of the reconciliation. The information it self is not used for anything in this PR - but it will be used in the future to address #9436 an possibly also #9434. It is done in a separate Pr to get it into the codebase before the 0.39 release to make sure we avoid any issues with upgrade later.Checklist