-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename *Resources.*StatefulSetName and deploymentName methods #9520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Could you please rebase it? As we just merged a PR that caused some conflicts. Thanks.
Signed-off-by: Anefu <[email protected]>
Signed-off-by: Anefu <[email protected]>
Signed-off-by: Anefu <[email protected]>
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
test/src/main/java/io/strimzi/test/k8s/KubeClusterResource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anefu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the tests side.
Thanks for the PR :) good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Type of change
Description
PR renames the *StatefulSetName methods to *ComponentName and deploymentName to componentName. Closes #9406.
Checklist