Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Innitial cleanup of AbstractST #9525

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Conversation

jankalinic
Copy link
Contributor

Type of change

  • Refactoring

Description

This PR is first part of AbstractST cleanup dealing with unnecessary variables stored multiple times on multiple places.

Checklist

  • Write tests
  • Make sure all tests pass
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

@jankalinic jankalinic self-assigned this Jan 8, 2024
@jankalinic jankalinic added this to the 0.40.0 milestone Jan 8, 2024
@jankalinic
Copy link
Contributor Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --profile=regression

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: regression
GROUPS:
TEST_CASE:
TOTAL: 284
PASS: 280
FAIL: 2
SKIP: 2
BUILD_NUMBER: 1
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

❗ Test Failures ❗

  • testMultipleRoutes in io.strimzi.systemtest.kafka.listeners.MultipleListenersST
  • testOperandsWithRestrictedSecurityProfile in io.strimzi.systemtest.security.PodSecurityProfilesST

Re-run command:
@strimzi-ci run tests --profile=regression --testcase=io.strimzi.systemtest.kafka.listeners.MultipleListenersST#testMultipleRoutes,io.strimzi.systemtest.security.PodSecurityProfilesST#testOperandsWithRestrictedSecurityProfile

@jankalinic jankalinic marked this pull request as ready for review January 9, 2024 12:09
@im-konge
Copy link
Member

im-konge commented Jan 9, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits 👍 Thanks for the PR

Signed-off-by: jkalinic <[email protected]>
@im-konge
Copy link
Member

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jankalinic jankalinic added ready for merge Label for PRs which are ready for merge and removed needs review labels Jan 12, 2024
@Frawless Frawless merged commit e347982 into strimzi:main Jan 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants