-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ST] Innitial cleanup of AbstractST #9525
Conversation
@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --profile=regression |
|
❌ Test Summary ❌TEST_PROFILE: regression ❗ Test Failures ❗
Re-run command: |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: jkalinic <[email protected]>
Signed-off-by: jkalinic <[email protected]>
Signed-off-by: jkalinic <[email protected]>
Signed-off-by: jkalinic <[email protected]>
4b46a06
to
cf1d1be
Compare
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits 👍 Thanks for the PR
systemtest/src/test/java/io/strimzi/systemtest/bridge/HttpBridgeTlsST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectST.java
Outdated
Show resolved
Hide resolved
...test/src/test/java/io/strimzi/systemtest/kafka/dynamicconfiguration/DynamicConfSharedST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/MultipleListenersST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/metrics/MetricsST.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jkalinic <[email protected]>
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
Type of change
Description
This PR is first part of AbstractST cleanup dealing with unnecessary variables stored multiple times on multiple places.
Checklist