Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In KafkaAgentClient use generic keystore password instead of p12 password #9538

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

katheris
Copy link
Contributor

Type of change

Select the type of your PR

  • Refactoring

Description

As part of issue 8721 the KafkaAgentClient was swapped to using the PEM certificate rather than the PKCS12 one. However when creating the JKS keystore for the client we still use the PKCS12 password. Since the keystore is never written to disk, the password is never used to verify the keystore, so it shouldn't matter what the password is. This change uses a generic password of "changeit" to remove dependence on the cluster-operator.password value in the Kubernetes secret.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@scholzj scholzj added this to the 0.40.0 milestone Jan 10, 2024
@scholzj
Copy link
Member

scholzj commented Jan 10, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member

scholzj commented Jan 15, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit 35e1306 into strimzi:main Jan 15, 2024
29 checks passed
adamj-m pushed a commit to jamesfarlow/strimzi-kafka-operator that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants