Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ST] Refactor logs collecting of systemtests and collect more data #9637

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[ST] Refactor logs collecting of systemtests and collect more data #9637

merged 1 commit into from
Feb 5, 2024

Conversation

kornys
Copy link
Contributor

@kornys kornys commented Feb 4, 2024

Type of change

  • Refactoring

Description

  1. Clean LogCollector class
  2. Do not call describe nodes for every namespace in case of testFail (it reduces time significantly)
  3. Do not create path by string comprehension but use proper Path.resolve() method
  4. Use Files.writeString for writing files
  5. Collect also configmaps and secrets

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Make sure all tests pass

@kornys kornys added this to the 0.40.0 milestone Feb 4, 2024
im-konge
im-konge approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kornys kornys added the ready for merge Label for PRs which are ready for merge label Feb 5, 2024
see-quick
see-quick approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@see-quick see-quick merged commit 49c7deb into strimzi:main Feb 5, 2024
13 checks passed
@kornys kornys deleted the st-logging branch February 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frawless Frawless Frawless approved these changes

@see-quick see-quick see-quick approved these changes

@im-konge im-konge im-konge approved these changes

Assignees
No one assigned
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Milestone
0.40.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kornys @Frawless @see-quick @im-konge