[ST] Node Pools role changes. Role change and scale down prevention if replicas present. #9693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do not merge before testNodePoolsRolesChanging |
henryZrncik
force-pushed
the
scale-prevented
branch
from
44868d4
to
7a137d8
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
henryZrncik
force-pushed
the
scale-prevented
branch
from
7a137d8
to
d311f3d
Compare
im-konge
reviewed
Feb 20, 2024
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaNodePoolST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaNodePoolST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaNodePoolST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaNodePoolST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/rollingupdate/KafkaRollerST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/rollingupdate/KafkaRollerST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/rollingupdate/KafkaRollerST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaNodePoolST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaNodePoolST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaNodePoolST.java
Outdated
Show resolved
Hide resolved
Signed-off-by: hzrncik <[email protected]>
henryZrncik
force-pushed
the
scale-prevented
branch
from
d311f3d
to
b1cd0ee
Compare
see-quick
approved these changes
Feb 22, 2024
systemtest/src/test/java/io/strimzi/systemtest/rollingupdate/KafkaRollerST.java
Outdated
Show resolved
Hide resolved
Signed-off-by: hzrncik <[email protected]>
|
/azp list |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
addition of checks when preventing Scale down or role change (removal of broker role) in case given nodes (brokers) still contains replicas.
addition of new test (which can be in a future further extended), to cover role changes. As currently the only role transition fully supported is from Mixed role to Controller only, test contains only that. I did not incorporated it into the other tests as this is so far kraft specific and would create a mess of resources creation in other node pools tests.
also test testCruiseControlDuringBrokerScaleUpAndDown is enabled and fixed (to work in kraft) as well, this was done instead of adding CC into Kafka Node Pool specific test as there would be too big overlap. some checks there were removed as they were redundant, only significant parts there are that we create sepate roles instead of calling
NodePoolsConverter.convertNodePoolsIfNeededas this test does not need to run in mixed mode. also there is annotation for specific Ids for controllers in order to not need to introduce additional logic into Rebalancing and ids which would be changed due to 3 extra (controllers) Ids taken.