Cleanup test certificate temp files #9707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Valeri <[email protected]>
fvaleri
requested review from
scholzj and
ppatierno
and removed request for
scholzj
scholzj
reviewed
Feb 19, 2024
Signed-off-by: Federico Valeri <[email protected]>
You are right, that's better. Thanks. I would like to keep the ClientAndServer wrapping in MockCruiseControl, which is useful to isolate test classes from the mockserver dependency. Wdyt? |
scholzj
approved these changes
Feb 19, 2024
...r-operator/src/test/java/io/strimzi/operator/cluster/operator/assembly/CaReconcilerTest.java
Show resolved
Hide resolved
Signed-off-by: Federico Valeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests leave a bunch of temporary files in the /tmp folder, which are used for certificate generation. This change adds code to clean them up after the test has finished. It also hides ClientAndServer in MockCruiseControl to isolate test classes from the mockserver dependency.