Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong escaping of OAuth configuration in Mirror Maker 2 #9799

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Mar 7, 2024

Type of change

  • Bugfix

Description

The OAuth configuration in Mirror Maker 2 seems to have some bad escaping. This PR fixes it. For some reason, we were also missing MM2 in system tests for OAuth with TLS encryption. So this PR adds the system test as well.

This should resolve #9786

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit, thanks

Signed-off-by: Jakub Scholz <[email protected]>
@scholzj
Copy link
Member Author

scholzj commented Mar 7, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit df3985e into strimzi:main Mar 8, 2024
21 checks passed
@scholzj scholzj deleted the fix-wrong-escaping-in-MM2-OAuth-config branch March 8, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fail to run Mirror Maker 2 connector task when using OAUTH to connect to kafka clusters
3 participants