Remove all beta features from Issuing APIs #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Mar 27, 2020
remi-stripe
force-pushed
the
remi-issuing-beta-remove
branch
2 times, most recently
from
76af702
to
e098e6b
Compare
ob-stripe
suggested changes
Mar 27, 2020
ob-stripe
approved these changes
Mar 27, 2020
|
@remi-stripe Quick note that I retargeted this PR to the major integration branch in #1055. |
remi-stripe
force-pushed
the
integration-v71
branch
from
8d70710
to
28c24cf
Compare
remi-stripe
force-pushed
the
remi-issuing-beta-remove
branch
from
a44bf0d
to
35aa632
Compare
remi-stripe
force-pushed
the
remi-issuing-beta-remove
branch
from
35aa632
to
edae9bc
Compare
issuing_cardholder.go
Outdated
| // This property is deprecated | ||
| Name string `json:"name"` | ||
| // IssuingCardholderCompany represents additional information about a | ||
| // business_entity cardholder. |
There was a problem hiding this comment.
s/business_entity/company in the docstring, too
issuing_cardholder.go
Outdated
| Address *AddressParams `form:"address"` | ||
|
|
||
| // This parameter is deprecated | ||
| Name *string `form:"name"` | ||
| } | ||
|
|
||
| // IssuingCardholderCompanyParams represents additional information about a |
There was a problem hiding this comment.
this docstring also needs s/business_entity/company now
richardm-stripe
approved these changes
Apr 16, 2020
remi-stripe
force-pushed
the
remi-issuing-beta-remove
branch
from
edae9bc
to
6218549
Compare
|
Fixed the comments issues so approving and merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the deprecated features from the Issuing API and renames all relevant classes to ensure we have the right structure for codegen.
r? @richardm-stripe @ob-stripe
cc @stripe/api-libraries
Note: Targets major version integration branch in #1055.