Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with information on Go modules #775

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Jan 16, 2019

Go module support will be reverted in #774. Here, we update the README
with some information about the status of Go modules in stripe-go, and
how to use the library with them for the time being.

r? @brandur (WIP.)

README.md Outdated
import (
"github.com/stripe/stripe-go/v55"
"github.com/stripe/stripe-go/v55/customer"
github.com/stripe/stripe-go/v55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is right. The modules Wiki has some information on this, but naturally provides no examples. Let me get #774 for in and just try it out to make sure I get the right invocation.

@brandur-stripe brandur-stripe force-pushed the brandur-update-readme branch 2 times, most recently from 34d1f73 to 7c525b4 Compare January 16, 2019 22:23
Go module support will be reverted in #774. Here, we update the README
with some information about the status of Go modules in stripe-go, and
how to use the library with them for the time being.
"github.com/stripe/stripe-go/v55"
"github.com/stripe/stripe-go/v55/customer"
"github.com/stripe/stripe-go"
"github.com/stripe/stripe-go/customer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified experimentally that this all seems to work.

@brandur-stripe
Copy link
Contributor

r? @remi-stripe Mind taking a look at this? Thanks!

@brandur-stripe
Copy link
Contributor

Thanks!

@brandur-stripe brandur-stripe merged commit d7738fe into master Jan 17, 2019
@brandur-stripe brandur-stripe deleted the brandur-update-readme branch January 17, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants