fix: Update logging to coerce ASCII-8BIT into UTF-8. #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
requested review from
a team and
kamil-stripe
and removed request for
a team
kamil-stripe
approved these changes
Jun 21, 2022
pakrym-stripe
added a commit
that referenced
this pull request
Jun 30, 2022
* fix: Update logging to coerce ASCII-8BIT into UTF-8. (#1076) * Add release/* and feature/* to PR CI triggers (#1080) * Add next-major-release to PR CI triggers * Update branch names * Rename release to sdk-release in CI triggers * API Updates (#1084) * Bump version to 6.5.0 * Set version to 6.5.0 to simplify merge * Reset version to 6.4.0 Co-authored-by: Dominic Charley-Roy <[email protected]> Co-authored-by: Kamil Pajdzik <[email protected]> Co-authored-by: Dominic Charley-Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @stripe/server-api-libraries-admins
Summary
Updates our logging utilities to transform any string encoded as ASCII-8bit (raw binary) to UTF-8 when logging out.
The strings returned from the server are in ASCII-8bit until the JSON marshaller transforms them to UTF-8. Unfortunately we have logging statements which pass the raw content sent back from the server. puts fails to interpret these as 8bit because they're actually utf-8 characters.
So, we force any binary string to actually be encoded as UTF-8 for the purposes of debug logging.
Alternatives:
Motivation
Fix #1059