Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for exchange_rates API requests #606

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Conversation

ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Oct 31, 2017

r? @brandur-stripe
cc @stripe/api-libraries @alixander-stripe

Followup to #605.

Now with singular API resource name. In retrospect, renaming the branch was probably unnecessary.

@stripe-ci
Copy link

@brandur-stripe
Copy link
Contributor

Alright, I've deployed those tweaks to the exchange rates API, so these should all be good to come in. Sorry about the churn OB, and thanks for sticking through it!

This one LGTM.

Now with singular API resource name. In retrospect, renaming the branch was probably unnecessary.

Haha, that is some pretty high-level pedantry :) Detail is important, but that might be too much finesse!

@brandur-stripe brandur-stripe merged commit 665af07 into master Oct 31, 2017
@brandur-stripe brandur-stripe deleted the ob-exchange-rate branch October 31, 2017 15:48
@brandur-stripe
Copy link
Contributor

Released as 3.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants