Handle file objects like file_upload

[ob-stripe]

r? @brandur-stripe
cc @stripe/api-libraries

• Renames the Stripe::FileUpload resource class to Stripe::File, and adds a FileUpload alias for the File class
• Changes the OBJECT_NAME from file_upload to file, and adds an OBJECT_NAME_ALT with value file_upload
• Updates convert_to_stripe_object to deserialize both file and file_upload objects into Stripe::File objects
• For tests: I've added a new file_test.rb file but also kept the original file_upload_test.rb file. This is probably unnecessary, and we could remove the latter and simply add a test to check that Stripe::FileUpload == Stripe::File. Let me know what you think is preferable.

[brandur-stripe]

Mind just adding a bit of a comment here explaining that these used to be two distinct objects that were then unified into one?

[brandur-stripe]

Also, sorry for the super nit, but just so this sorts nicely, do you think we could go OBJECT_NAME_ALT? :)

[brandur-stripe]

• For tests: I've added a new file_test.rb file but also kept the original file_upload_test.rb file. This is probably unnecessary, and we could remove the latter and simply add a test to check that Stripe::FileUpload == Stripe::File. Let me know what you think is preferable.

I think what you've done here is the right move for now.

Left a few minor nits, but LGTM. I think your tests were failing due to an intermittent Travis problem, so I restarted one of the builds in the matrix.

ptal @ob-stripe

[ob-stripe]

Fixed, ptal @brandur-stripe

[brandur-stripe]

LGTM.

[ob-stripe]

I pushed a second commit to make it so that files.stripe.com is only used for the create request. ptal @brandur-stripe

[ob-stripe]

This is a bit awkward, but it's necessary because if api_base and uploads_base have the same value, then assert_requested is not actually asserting that the request is for the correct host.

[brandur-stripe]

Good point. It may be worth adding a comment that notes that api_base will be reset between every test case so this won't mutate the global state of test runs that come after it.

[brandur-stripe]

We may eventually want to rename this to files_base for consistency.

[ob-stripe]

Yeah, I thought of that but was afraid it should count as a breaking change. wdyt?

[brandur-stripe]

Ah, true (although hopefully no one's overriding this). It does seem less churnful to just leave it for now though, so NM. If we ever feel strongly about it later, we can always change it then.

[brandur-stripe]

Minor comment above, but LGTM.

[ob-stripe]

Released as 3.27.0.