Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate OAuth authorize URLs for express accounts #719

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Dec 31, 2018

Connect with Express accounts uses a slightly different version of the
OAuth authorize URL [1] in that it's prefixed with /express.

Here we add a new option to Stripe::OAuth.authorize_url which allows
express: true to be passed in to generate the Express variant.

Note that the token endpoint has no equivalent so we don't need the
option there.

Fixes #717.

r? @ob-stripe

[1] https://stripe.com/docs/connect/oauth-reference#express-account-differences

Connect with Express accounts uses a slightly different version of the
OAuth authorize URL [1] in that it's prefixed with `/express`.

Here we add a new option to `Stripe::OAuth.authorize_url` which allows
`express: true` to be passed in to generate the Express variant.

Note that the token endpoint has no equivalent so we don't need the
option there.

Fixes #717.

[1] https://stripe.com/docs/connect/oauth-reference#express-account-differences
Copy link

@Meekohi Meekohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response!

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @brandur-stripe!

@ob-stripe ob-stripe assigned brandur-stripe and unassigned ob-stripe Jan 1, 2019
@brandur-stripe
Copy link
Contributor

Thanks guys!

@brandur-stripe brandur-stripe merged commit 365759e into master Jan 2, 2019
@brandur-stripe
Copy link
Contributor

Released as 4.5.0.

@ob-stripe ob-stripe deleted the brandur-support-express-authorize branch January 9, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add express endpoints for OAuth
5 participants