Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer the request_id from the http_headers to error. #845

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Transfer the request_id from the http_headers to error. #845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/stripe/errors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def initialize(message = nil, http_status: nil, http_body: nil,
@http_headers = http_headers || {}
@json_body = json_body
@code = code
@request_id = @http_headers[:request_id]
@request_id = @http_headers["request-id"]
@error = construct_error_object
end

Expand Down
2 changes: 1 addition & 1 deletion test/stripe/errors_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class StripeErrorTest < Test::Unit::TestCase
e = StripeError.new("message", http_status: 200)
assert_equal "(Status 200) message", e.to_s

e = StripeError.new("message", http_status: nil, http_body: nil, json_body: nil, http_headers: { request_id: "request-id" })
e = StripeError.new("message", http_status: nil, http_body: nil, json_body: nil, http_headers: { "request-id" => "request-id" })
assert_equal "(Request request-id) message", e.to_s
end
end
Expand Down