Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Improve logs with more specific errors #128

Closed
camposer opened this issue Sep 23, 2021 · 0 comments · Fixed by #176
Closed

Improve logs with more specific errors #128

camposer opened this issue Sep 23, 2021 · 0 comments · Fixed by #176
Labels
enhancement New feature or request

Comments

@camposer
Copy link
Contributor

Improve errors that we log. Log specific messages when...

  • The channel is archived (error)
  • The all user admins are deactivated (error)
  • The bot is not in the admin channel (error)
@camposer camposer added the enhancement New feature or request label Sep 23, 2021
wallrony added a commit to strongdm/errbot-slack-bolt-backend that referenced this issue Dec 2, 2021
@wallrony @vassalo
Add logs and feedback messages for slack errors (strongdm/accessbot#128)
b5be1c0 
Co-authored-by: vassalo <[email protected]>
wallrony added a commit to strongdm/errbot-slack-bolt-backend that referenced this issue Dec 2, 2021
@wallrony @vassalo
Remove debug prints (strongdm/accessbot#128)
8876ca4 
Co-authored-by: vassalo <[email protected]>
wallrony added a commit that referenced this issue Dec 2, 2021
@wallrony @vassalo
Add logs and feedback messages for slack errors (#128)
3a930e8 
Co-authored-by: vassalo <[email protected]>
This was referenced Dec 2, 2021
Closed
Merged
Merged
wallrony added a commit that referenced this issue Dec 3, 2021
@wallrony @vassalo
Add fail-safe behavior for has_active_admins (#128)
ba8dbed 
Co-authored-by: vassalo <[email protected]>
wallrony added a commit to strongdm/errbot-slack-bolt-backend that referenced this issue Dec 9, 2021
@wallrony @vassalo
Fix user real_name optional attr (strongdm/accessbot#128)
ef971b2 
Co-authored-by: vassalo <[email protected]>
wallrony added a commit that referenced this issue Dec 9, 2021
@wallrony @vassalo
Add prevent manual grant without administration (#128)
70c5908 
Co-authored-by: vassalo <[email protected]>
wallrony added a commit that referenced this issue Dec 13, 2021
@wallrony
Fix needs_auto_approve sdm_account argument (#128)
4e2e9e5
vassalo added a commit that referenced this issue Dec 13, 2021
@vassalo @wallrony
Add show profile (#128)
23c78a2 
Co-authored-by: wallrony <[email protected]>
vassalo added a commit that referenced this issue Dec 17, 2021
@vassalo @wallrony
Refactor grant_access flow and has_active_admins method (#128)
b6f6889 
Co-authored-by: wallrony <[email protected]>
vassalo added a commit to strongdm/errbot-slack-bolt-backend that referenced this issue Dec 17, 2021
@vassalo @wallrony
Add tests for build_identifier (strongdm/accessbot#128)
2445a0c 
Co-authored-by: wallrony <[email protected]>
vassalo added a commit to strongdm/errbot-slack-bolt-backend that referenced this issue Jan 27, 2022
@vassalo @wallrony
Fix msg.frm identifier and add email property in SlackRoomOccupant (s…
f209257 
…trongdm/accessbot#128)

Co-authored-by: wallrony <[email protected]>
vassalo added a commit to strongdm/errbot-slack-bolt-backend that referenced this issue Jan 27, 2022
@vassalo @wallrony
Fix build_identifier tests (strongdm/accessbot#128)
0d45b48 
Co-authored-by: wallrony <[email protected]>
vassalo added a commit to strongdm/errbot-slack-bolt-backend that referenced this issue Jan 28, 2022
@vassalo @wallrony
Improve SlackPerson constructor (strongdm/accessbot#128)
ef126b5 
Co-authored-by: wallrony <[email protected]>
camposer added a commit that referenced this issue Jan 28, 2022
@camposer
Update errbot-slack module (#128)
52a1438
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logs and feedback messages for slack errors strongdm/accessbot
1 participant
@camposer