Proof of duplicate data and reason for cleanDatasources #41

jrschumacher · 2015-01-20T03:42:52Z

No description provided.

Seems unintuitive, makes assertions with counting very difficult to understand, makes cleaning up data difficult to do, etc ``` whenCalledRemotely .create POST /xxx-test-models ✓ should call the method over rest 1) should only create one model .findById GET /<dynamic> ✓ should retrieve the expected model in the first test ✓ should retrieve the expected model in subsequent tests 32 passing (92ms) 1 failing 1) helpers whenCalledRemotely .create POST /xxx-test-models should only create one model: AssertionError: {"id":2} == {"id":3} ```

…ed up the data which is why I want the ability to clean datasources. ``` test GET /xxx-test-models [ { id: 2 }, { id: 3 }, { id: 6 } ] ```

slnode · 2015-01-20T03:42:53Z

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

bajtos · 2015-01-20T15:58:38Z

As I commented elsewhere, this would be fixed by adding beforeEach.givenModel.

I think it makes sense to add the tests from this patch though, can you include them in #40 please?

bajtos · 2015-01-20T15:59:03Z

@ritch I am assigning the PR to you since you are reviewing #40 too.

jrschumacher · 2015-01-20T17:13:38Z

I think it makes sense to add the tests from this patch though, can you include them in #40 please?

Yes

jrschumacher · 2015-01-27T17:54:54Z

@ritch closing as this PR is only an proof to the issue

Ryan Schumacher added 2 commits January 19, 2015 22:37

Because it's in a separate describe I'd imagine it would have clean…

e97141a

…ed up the data which is why I want the ability to clean datasources. ``` test GET /xxx-test-models [ { id: 2 }, { id: 3 }, { id: 6 } ] ```

altsang added the #community contribution label Jan 20, 2015

bajtos assigned ritch Jan 20, 2015

jrschumacher closed this Jan 27, 2015

altsang removed the #community contribution label Jan 27, 2015

bajtos unassigned ritch Aug 10, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proof of duplicate data and reason for cleanDatasources #41

Proof of duplicate data and reason for cleanDatasources #41

jrschumacher commented Jan 20, 2015

slnode commented Jan 20, 2015

bajtos commented Jan 20, 2015

bajtos commented Jan 20, 2015

jrschumacher commented Jan 20, 2015

jrschumacher commented Jan 27, 2015

Proof of duplicate data and reason for cleanDatasources #41

Proof of duplicate data and reason for cleanDatasources #41

Conversation

jrschumacher commented Jan 20, 2015

slnode commented Jan 20, 2015

bajtos commented Jan 20, 2015

bajtos commented Jan 20, 2015

jrschumacher commented Jan 20, 2015

jrschumacher commented Jan 27, 2015