This repository has been archived by the owner on May 29, 2019. It is now read-only.
Typo: whenCalledUnauthenticated should use givenAnUnauthenticatedToken() #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
… or 401 - it.shouldBeDenied() will expect 401 only. - it.shouldBeDeniedWhenCalledByUser() uses it.shouldBeDeniedByAcl() - it.shouldBeDeniedWhenCalledByUserWithRole() uses it.shouldBeDeniedByAcl() http://docs.strongloop.com/display/public/LB/config.json strongloop/loopback#1513
…or out if the model already existed in DB
givenUserModel() can now won't conflict with the functions below: - givenLoggedInUser() - whenLoggedInAsUser() - whenCalledByUser() - shouldBeXXXWhenCalledByUser()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it was an copy and paste error ('givenAnAnonymousToken' instead of givenAnUnauthenticatedToken)